[4주차] 이건희/[feat] 추가 API 구현#147
Open
KunHeeLee7 wants to merge 4 commits intoLeets-Official:이건희/mainfrom
Hidden character warning
The head ref may contain hidden characters: "\uc774\uac74\ud76c/4\uc8fc\ucc28"
Open
Conversation
Nanajun22
reviewed
Apr 29, 2026
| return PostReportResponseDTO.builder() | ||
| .reportId(report.getReportId()) | ||
| .postId(report.getPost().getPostId()) | ||
| .reporterId(report.getReporter().getUserId()) |
There was a problem hiding this comment.
해당 메서드는 DTO 생성주기를 service에서 관리하게 되어서 dto 수정시 service 까지 수정해야 해서 유지보수의 어려움이 있을것같습니다 DTO안에서 직접 해당 메서드를 관리하면 DTO가 자기자신의 생명주기를 전부 관리하게 되므로 높은 응집도를 가져 좋은 설계가 될 것 같습니다.
Nanajun22
reviewed
Apr 30, 2026
| @Table(name = "post_reports") | ||
| @Getter | ||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| public class PostReport extends BaseReport { |
There was a problem hiding this comment.
현재 설계에서는 report 타입 별로 데이터베이스 테이블을 따로 가지기 때문에 관리가 힘들고 새로운 도메인에 대한 신고 기능을 구현할 때 기존 코드를 재사용하기 힘들어 확장성이 떨어지는 단점이 있을 것 같습니다. 똑같은 기능을 구현할 때 다양한 설계와 장단점들을 고려해보는 것도 좋을 것 같습니다.
kangyeson
reviewed
Apr 30, 2026
kangyeson
left a comment
kangyeson
left a comment
There was a problem hiding this comment.
GlobalExceptionHandler로 전체 공통 예외처리 폼을 구현하신 점 좋습니다! 고생하셨습니다~!🐶
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. 과제 요구사항 중 구현한 내용
2. 핵심 변경 사항
3. 실행 및 검증 결과
게시글 숨김 처리
게시글 숨김 처리 권한 없을 시 예외처리
게시글 신고
게시글 중복 신고 예외처리
관리자에 의한 게시글 숨김 처리
4. 완료 사항
5. 추가 사항
제출 체크리스트
{이름}/main브랜치다{이름}/{숫자}주차브랜치다Reviewer 참고